fix: handle nested parenthesis and brackets in ShortFuncName#17
Conversation
Improved ShortFuncName to recursively shorten package paths in nested generics and receiver types. Added comprehensive tests covering various edge cases. Co-authored-by: xkilldash9x <223238109+xkilldash9x@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
xkilldash9x
deleted the
fix-shortfuncname-generics-10983289181726047250
branch
1 participant
Fixed an issue where
ShortFuncNamedid not correctly handle nested generics and complex function signatures, failing to strip package paths from inner types.Implemented a lexer-based approach to tokenize the function name and shorten each component individually.
Added
pkg/diff/topology_match_test.gowith extensive test cases.PR created automatically by Jules for task 10983289181726047250 started by @xkilldash9x